Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrectly named service named 'Profile' #3562

Merged
merged 5 commits into from
Dec 2, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Dec 1, 2020

Removes an incorrectly named service Profile that was included in release, v2.801.0

Verified locally that class AWS.Profile is removed.

Code
const AWS = require("../aws-sdk-js");

(async () => {
  const region = "us-west-2";
  const client = new AWS.Profile({ region });
  console.log(await client.listDomains({}).promise());
})();
Output
(node:40502) UnhandledPromiseRejectionWarning: TypeError: AWS.Profile is not a constructor
    at /Users/trivikr/workspace/test-service-profile/index.js:5:18
    at Object.<anonymous> (/Users/trivikr/workspace/test-service-profile/index.js:7:3)
    at Module._compile (internal/modules/cjs/loader.js:1063:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1092:10)
    at Module.load (internal/modules/cjs/loader.js:928:32)
    at Function.Module._load (internal/modules/cjs/loader.js:769:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:72:12)
    at internal/main/run_main_module.js:17:47
(Use `node --trace-warnings ...` to show where the warning was created)
(node:40502) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:40502) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
Checklist
  • npm run test passes
  • .d.ts file is updated
  • changelog is added, npm run add-change

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation

This comment has been minimized.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-v2-github
  • Commit ID: 581fefa
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr trivikr merged commit b6401d0 into aws:master Dec 2, 2020
@trivikr trivikr deleted the remove-service-profile branch December 2, 2020 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants