feat: add dismissible Node.js <10.x deprecation notice #3880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AllanZhengYP
approved these changes
Sep 3, 2021
trivikr
changed the title
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API reference can be viewed at: https://aws-sdk-js-3880.netlify.app/aws/s3
Verified that notice is not shown after it's dismissed, till the cookies are cleared.
Screen recording
nodeVersionNotice.mov
Screenshots:
By default key `nodeVersionNoticeDismissed` is not set
The key `nodeVersionNoticeDismissed` is set when version notice is dismissed
Checklist
bundle exec rake docs:apiand inspectdoc/latest/index.htmlif documentation is changed