Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ResourceExplorer2): set endpoint to dualstack by default #4263

Merged
merged 2 commits into from Nov 4, 2022

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Nov 4, 2022

Internal JS-3686

Testing

import AWS from "./index";

(async () => {
  const client1 = new AWS.ResourceExplorer2({ region: "us-west-2" });
  console.log("default endpoint:", client1.config.endpoint);

  const client2 = new AWS.ResourceExplorer2({
    region: "us-west-2",
    useDualstackEndpoint: false,
  });
  console.log(
    "endpoint with useDualstackEndpoint=false:",
    client2.config.endpoint
  );

  const client3 = new AWS.ResourceExplorer2({
    region: "us-west-2",
    useDualstackEndpoint: true,
  });
  console.log(
    "endpoint with useDualstackEndpoint=true:",
    client3.config.endpoint
  );
})();
default endpoint: resource-explorer-2.us-west-2.api.aws
endpoint with useDualstackEndpoint=false: resource-explorer-2.us-west-2.api.aws
endpoint with useDualstackEndpoint=true: resource-explorer-2.us-west-2.api.aws
Checklist
  • npm run test passes
  • changelog is added, npm run add-change

@trivikr trivikr requested a review from a team as a code owner November 4, 2022 16:41
@trivikr trivikr changed the title fix(ResourceExplorer2): set dualstack endpoint by default fix(ResourceExplorer2): set endpoint to dualstack by default Nov 4, 2022
@trivikr trivikr merged commit c98afb1 into aws:master Nov 4, 2022
@trivikr trivikr deleted the dualstackByDefault-override branch November 4, 2022 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants