Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: distributed write text regression, change to singledispatch, add repartitioning utility #1611

Merged
merged 7 commits into from
Sep 21, 2022

Conversation

kukushking
Copy link
Contributor

@kukushking kukushking commented Sep 15, 2022

Feature or Bugfix

  • Bugfix

Detail

  • read text functions were calling distributed versions of _to_partititons and _to_dataset - as a temporary fix, added casting to pandas dataframe until distributed implementation for _write_text is available
  • use singledispatch to dispatch between distributed and non-distributed versions of _to_parquet, _to_partititons and _to_dataset
  • add modin repartitioning decorator utility

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking kukushking changed the title Fix distributed write text regression fix: distributed write text regression Sep 15, 2022
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 9d725e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
  • Commit ID: 9d725e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
  • Commit ID: 9d725e2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking marked this pull request as ready for review September 16, 2022 15:41
@kukushking kukushking changed the title fix: distributed write text regression fix: distributed write text regression, change to singledispatch Sep 16, 2022
@kukushking kukushking changed the title fix: distributed write text regression, change to singledispatch fix: distributed write text regression, change to singledispatch, add repartitioning Sep 16, 2022
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 0b97210
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
  • Commit ID: 0b97210
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking changed the title fix: distributed write text regression, change to singledispatch, add repartitioning fix: distributed write text regression, change to singledispatch, add repartitioning utility Sep 16, 2022
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
  • Commit ID: 0b97210
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit 5e91b19 into release-3.0.0 Sep 21, 2022
@jaidisido jaidisido deleted the fix/distributed-write-text-regression branch September 21, 2022 09:40
@kukushking kukushking self-assigned this Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants