Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): Return address config param #1660

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Conversation

kukushking
Copy link
Contributor

Ray does not always set RAY_ADDRESS environment variable that we use to detect a running cluster and connect to it. Adding address parameter back to be able to set conventional WR_ADDRESS and connect to a cluster instead of always creating a local cluster.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: f0165e8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
  • Commit ID: f0165e8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
  • Commit ID: f0165e8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking merged commit d218d79 into release-3.0.0 Oct 7, 2022
@malachi-constant malachi-constant deleted the fix-3.0/address-param branch October 7, 2022 17:19
@kukushking kukushking self-assigned this Nov 28, 2022
@kukushking kukushking added this to the 3.0.0 milestone Nov 28, 2022
@kukushking kukushking added the bug Something isn't working label Nov 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants