support for test infrastructure in private subnets #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnfait
force-pushed
the
private-test-infra
branch
from
5294889
to
a23f65b
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
force-pushed
the
private-test-infra
branch
2 times, most recently
from
ccd26f7
to
3a4b496
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
force-pushed
the
private-test-infra
branch
2 times, most recently
from
0e43c60
to
2e601ed
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
force-pushed
the
private-test-infra
branch
3 times, most recently
from
d81cc4a
to
06e6c48
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
force-pushed
the
private-test-infra
branch
from
06e6c48
to
09ae2da
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
force-pushed
the
private-test-infra
branch
from
09ae2da
to
90e7cf2
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
force-pushed
the
private-test-infra
branch
from
90e7cf2
to
b9da28a
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
force-pushed
the
private-test-infra
branch
2 times, most recently
from
885abb8
to
18825b6
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
requested review from
malachi-constant,
kukushking,
jaidisido and
LeonLuttenberger
cnfait
added
dependencies
cnfait
force-pushed
the
private-test-infra
branch
from
18825b6
to
87f3804
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
jaidisido
approved these changes
Oct 21, 2022
poetry installation through pip bugged out, using the preferred method for install instead poetry 1.2+ doesn't like ubuntu's way of naming python packages (which is not PEP-440 compliant), work in a virtual env instead
cnfait
force-pushed
the
private-test-infra
branch
from
87f3804
to
9505f5f
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
Add the ability to run the test infrastructure without public IPs/domains (i.e. in VPC's private subnets)
networkcan be set topublic, else it defaults to private infrastructureThe Glue connection subnet is always private ("No public IP addresses are assigned")
The Redshift cluster subnet group was retained on stack deletion, added removal policy to destroy it instead
regenerate poetry.lock following poetry 1.2.2 update
our cfn-nag github workflow wasn't working reliably, I fixed it as part of this PR:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.