upgrade engine versions to match defaults from aws console #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenSearch is following semver (contrary to ES) and AWS console does not list < 1.3 any longer
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
requested review from
malachi-constant,
jaidisido,
kukushking and
LeonLuttenberger
jaidisido
approved these changes
Oct 25, 2022
LeonLuttenberger
approved these changes
Oct 25, 2022
malachi-constant
approved these changes
Oct 25, 2022
kukushking
approved these changes
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
_setup_opensearch_1. I'm expecting OpenSearch 2 to be available eventually and when that is the case we can add_setup_opensearch_2.rds.OracleEngineVersion.VER_19. We might prefer keeping a specific version but that is in line with what we do for SQL Server (rds.SqlServerEngineVersion.VER_15).By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.