Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Remove upper bound limit on 'python' version #1720

Merged
merged 3 commits into from
Oct 28, 2022

Conversation

malachi-constant
Copy link
Contributor

Dependency Update

  • Remove upper bound limit on 'python' version

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant linked an issue Oct 26, 2022 that may be closed by this pull request
@malachi-constant malachi-constant self-assigned this Oct 26, 2022
@malachi-constant malachi-constant added the dependencies Pull requests that update a dependency file label Oct 26, 2022
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: b21e94b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will want to regenerate the poetry.lock as a result. Then later we will need to do the same for release-3.0.0

@malachi-constant
Copy link
Contributor Author

You will want to regenerate the poetry.lock as a result. Then later we will need to do the same for release-3.0.0

Looks like we have this problem upstream, not sure if it's just isort or that was just the first package to error out.

The current project's Python requirement (>=3.7.1) is not compatible with some of the required packages Python requirement:
  - isort requires Python >=3.6.1,<4.0, so it will not be satisfied for Python >=4.0
  - isort requires Python >=3.6.1,<4.0, so it will not be satisfied for Python >=4.0
  - isort requires Python >=3.6.1,<4.0, so it will not be satisfied for Python >=4.0
  - isort requires Python >=3.6.1,<4.0, so it will not be satisfied for Python >=4.0

Because no versions of isort match >5.9.2,<5.9.3 || >5.9.3,<5.10.0 || >5.10.0,<5.10.1 || >5.10.1,<6.0.0
 and isort (5.9.2) requires Python >=3.6.1,<4.0, isort is forbidden.
And because isort (5.9.3) requires Python >=3.6.1,<4.0
 and isort (5.10.0) requires Python >=3.6.1,<4.0, isort is forbidden.
So, because isort (5.10.1) requires Python >=3.6.1,<4.0
 and awswrangler depends on isort (^5.9.2), version solving failed.

  • Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties

    For isort, a possible solution would be to set the `python` property to ">=3.7.1,<4.0"
    For isort, a possible solution would be to set the `python` property to ">=3.7.1,<4.0"
    For isort, a possible solution would be to set the `python` property to ">=3.7.1,<4.0"
    For isort, a possible solution would be to set the `python` property to ">=3.7.1,<4.0"

    https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies,
    https://python-poetry.org/docs/dependency-specification/#using-environment-markers

@kukushking
Copy link
Contributor

Upper bound >=3.7.1,<4.0 seems reasonable - do any other packages complain if you put that in?

@malachi-constant
Copy link
Contributor Author

Upper bound >=3.7.1,<4.0 seems reasonable - do any other packages complain if you put that in?

Seems to work fine with<4.0 as an upper limit.

@cnfait cnfait self-requested a review October 27, 2022 09:44
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 8102163
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit e6287c7 into main Oct 28, 2022
@malachi-constant malachi-constant deleted the 1714-remove-upper-bound-on-python_requires branch October 28, 2022 15:35
@kukushking kukushking added this to the 2.18.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove upper bound on python_requires
5 participants