read_csv: read file as binary when encoding_errors is set to ignore #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnfait
force-pushed
the
read-csv-encoding-errors-param
branch
from
16410de
to
0c3de78
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
cnfait
requested review from
kukushking,
jaidisido,
LeonLuttenberger and
malachi-constant
|
Would you add a test case covering this, please? |
cnfait
force-pushed
the
read-csv-encoding-errors-param
branch
from
39bcd61
to
f9cb833
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
added a test case where a UnicodeDecodeError is raised by default, and not raised when adding |
malachi-constant
approved these changes
Oct 27, 2022
jaidisido
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
read_csvchokes on encoding errors even when passingencoding_errors='ignore'. This happens due to ours casting the S3 object toTextIOWrapperafter retrieving it and passing that topd.read_csv.encoding_errors='ignore'we now keep the object as a set of bytes (mode=rb). In this case pandas is now responsible for wrapping this in a TextIOWrapper and deals with encoding and encoding errors.I'm actually thinking we should never wrap the S3 object into a TextIOWrapper ourselves - as far as I can tell there is no advantage doing that and pandas will take care of it anyway.
modeshould always be set torbin our code... but I'm curious about others' opinion!Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.