Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Fixing index column validation in s3.read.parquet() validate schema #1735

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented Oct 31, 2022

Bug

  • Fixing index column validation in s3.read.parquet() validate schema.
  • Add test case to validate the above.

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant self-assigned this Oct 31, 2022
@malachi-constant malachi-constant added the bug Something isn't working label Oct 31, 2022
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: cbc282e
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: cbc282e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch!

@malachi-constant malachi-constant merged commit 691a050 into main Nov 1, 2022
@malachi-constant malachi-constant deleted the 1717-bug-validate_schema-attribute-of-s3read_parquet-fails-on-index-columns branch November 1, 2022 16:17
@kukushking kukushking added this to the 2.18.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: validate_schema attribute of s3.read_parquet fails on index columns
4 participants