Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) Make tqdm progress reporting opt-in #1741

Merged
merged 3 commits into from
Nov 3, 2022
Merged

(feat) Make tqdm progress reporting opt-in #1741

merged 3 commits into from
Nov 3, 2022

Conversation

kukushking
Copy link
Contributor

@kukushking kukushking commented Nov 2, 2022 •
edited

tqdm progress bar should be opt-in instead of installed with ray extra by default. It's only required when a user expects to run the script and observe live output, otherwise it's polluting stderr.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking kukushking added this to the 3.0.0 milestone Nov 2, 2022
@kukushking kukushking self-assigned this Nov 2, 2022
LeonLuttenberger
LeonLuttenberger reviewed Nov 2, 2022
View reviewed changes
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious if there's a way we can disable it via an environment variable if tqdm is installed. The problem is that I don't like the idea of "if you happen to have this thing installed we'll pollute your stdout".

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: a4f1160
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
  • Commit ID: a4f1160
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking
Copy link
Contributor Author

kukushking commented Nov 2, 2022 •
edited

@LeonLuttenberger When you call tqdm there is disable option but ray aren't doing that upstream.

I wouldn't put any extra safety checks, IMO one mechanism by which the user can control this behavior is enough. Especially if it's more development time concern (in production your environments should only contain what is necessary).

@kukushking
Copy link
Contributor Author

@LeonLuttenberger also disabling by env variable wouldn't be opt-in. Imagine having to install an unnecessary dependency on the workers of your cluster only then to disable in via an env variable.

@LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger When you call tqdm there is disable option but ray aren't doing that upstream.

I wouldn't put any extra safety checks, IMO one mechanism by which the user can control this behavior is enough. Especially if it's more development time concern (in production your environments should only contain what is necessary).

That's a good point. I was hoping there would be an environment variable in Ray that we could plug into easily, but you're right, it's not a big deal either way.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
  • Commit ID: a4f1160
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 026e9ce
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubLoadTests5656BB24-s6u9F3qN9oFy
  • Commit ID: 026e9ce
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubStandardCodeBuild8C06-llutOAimTATs
  • Commit ID: 026e9ce
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking merged commit f583dd1 into release-3.0.0 Nov 3, 2022
@malachi-constant malachi-constant deleted the feat/opt-in-tqdm branch November 3, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malachi-constant malachi-constant malachi-constant approved these changes

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@jaidisido jaidisido Awaiting requested review from jaidisido

@cnfait cnfait Awaiting requested review from cnfait

Assignees

@kukushking kukushking

Labels
feature
Projects
AWS SDK for pandas roadmap
Awaiting triage
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kukushking @malachi-constant @LeonLuttenberger