Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: map datatype issue of athena #1753

Merged
merged 2 commits into from
Nov 11, 2022
Merged

fix: map datatype issue of athena #1753

merged 2 commits into from
Nov 11, 2022

Conversation

pal0064
Copy link
Contributor

@pal0064 pal0064 commented Nov 9, 2022

  • Bugfix

Detail

  • Athena does not allow space between map types.
    e.g. map<STRING, STRING> will give error while querying but map<STRING,STRING> won't

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Athena does not allow space between map types.
e.g. map<STRING, STRING> will give error while querying but map<STRING,STRING> won't
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 6c98b84
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pal0064
Copy link
Contributor Author

pal0064 commented Nov 9, 2022

AWS CodeBuild failed because of the botocore exceptions. Does not seem to be related to the current changes.

ERROR tests/test_timestream.py::test_empty_query[False] - botocore.exceptions...
ERROR tests/test_timestream.py::test_versioned - botocore.exceptions.ClientEr...

@malachi-constant
Copy link
Contributor

AWS CodeBuild failed because of the botocore exceptions. Does not seem to be related to the current changes.

ERROR tests/test_timestream.py::test_empty_query[False] - botocore.exceptions... ERROR tests/test_timestream.py::test_versioned - botocore.exceptions.ClientEr...

@pal0064 Yes, this is not related to your change. I'll trigger the tests again as I believe this issue is intermittent. If it fails again we will investigate separately.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 6c98b84
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@pal0064
Copy link
Contributor Author

pal0064 commented Nov 9, 2022

AWS CodeBuild failed because of the botocore exceptions. Does not seem to be related to the current changes.
ERROR tests/test_timestream.py::test_empty_query[False] - botocore.exceptions... ERROR tests/test_timestream.py::test_versioned - botocore.exceptions.ClientEr...

@pal0064 Yes, this is not related to your change. I'll trigger the tests again as I believe this issue is intermittent. If it fails again we will investigate separately.

cool thanks for letting me know.

@jaidisido jaidisido merged commit f959628 into aws:main Nov 11, 2022
@kukushking kukushking added this to the 2.18.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants