Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timestream endpoint tests #1781

Merged
merged 8 commits into from
Nov 17, 2022
Merged

Fix timestream endpoint tests #1781

merged 8 commits into from
Nov 17, 2022

Conversation

LeonLuttenberger
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Reverting the change to timestream endpoints

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant

This comment was marked as outdated.

Sign in to view
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: c9bd38c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger self-assigned this Nov 17, 2022
@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review November 17, 2022 17:55
malachi-constant
malachi-constant approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@malachi-constant malachi-constant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, any opportunity for us to add a quick note in documentation on setting endpoint url to a timestream interface endpoint?

@LeonLuttenberger
Copy link
Contributor Author

Looks good, any opportunity for us to add a quick note in documentation on setting endpoint url to a timestream interface endpoint?

Good call, I added a description to the config properties

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 7440dcf
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger merged commit b981a20 into main Nov 17, 2022
@LeonLuttenberger LeonLuttenberger deleted the fix/timestream-endpoint-tests branch November 17, 2022 21:38
LeonLuttenberger added a commit that referenced this pull request Nov 17, 2022
@LeonLuttenberger
Fix timestream endpoint tests (#1781)
13e3e11
@kukushking kukushking added this to the 2.18.0 milestone Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malachi-constant malachi-constant malachi-constant approved these changes

@jaidisido jaidisido jaidisido approved these changes

@cnfait cnfait Awaiting requested review from cnfait

@kukushking kukushking Awaiting requested review from kukushking

Assignees

@LeonLuttenberger LeonLuttenberger

Labels
None yet
Projects
None yet
Milestone
2.18.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeonLuttenberger @malachi-constant @jaidisido @kukushking