Test infra: Add NAT gateway IP addresses to base stack SSM parameters #1847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
malachi-constant
approved these changes
Dec 6, 2022
LeonLuttenberger
force-pushed
the
test-infra/add-eips-to-stack-output
branch
from
2d92257
to
793f724
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jaidisido
approved these changes
Dec 7, 2022
LeonLuttenberger
changed the title
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
The NAT Gateway IPs need to be added in one of the security groups for our CodeBuild. Right now, this is performed manually and is therefore not present in infrastructure-as-code. This PR is adding the IP addresses as SSM parameters to the base stack, so that we can use them from the CodeBuild definitions.
The SSM parameters will be the following:
/SDKPandas/VPC/PublicSubnet1/EIP/SDKPandas/VPC/PublicSubnet2/EIP/SDKPandas/VPC/PublicSubnet3/EIPBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.