Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coverage report to tox #1874

Merged
merged 4 commits into from
Dec 16, 2022
Merged

Add coverage report to tox #1874

merged 4 commits into from
Dec 16, 2022

Conversation

LeonLuttenberger
Copy link
Contributor

Feature or Bugfix

  • Feature

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review December 15, 2022 20:19
@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, the only downside is that when running the UnitTests CB, it will produce 4 coverage files (one per Python version) when only one is needed

Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 785f966
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger merged commit 5fd8fa9 into main Dec 16, 2022
@LeonLuttenberger LeonLuttenberger deleted the coverage-report-codebuild branch December 16, 2022 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants