Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix): missing timestamp data type in Timestream #1881

Merged
merged 2 commits into from
Dec 16, 2022
Merged

(fix): missing timestamp data type in Timestream #1881

merged 2 commits into from
Dec 16, 2022

Conversation

jaidisido
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Add datetime related data types to pyarrow2timestream conversion method
  • Handle edge case of timestamp conversion
  • Add test

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido jaidisido self-assigned this Dec 16, 2022
@kukushking kukushking merged commit 3ec0145 into main Dec 16, 2022
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 26413d6
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido deleted the fix/issue-1853-timestream branch December 16, 2022 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@malachi-constant malachi-constant Awaiting requested review from malachi-constant

Assignees

@jaidisido jaidisido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jaidisido @malachi-constant @kukushking @LeonLuttenberger