Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Athena cache unit test errors #1883

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Fix the Athena cache unit test errors #1883

merged 3 commits into from
Dec 19, 2022

Conversation

LeonLuttenberger
Copy link
Contributor

Feature or Bugfix

  • Bugfix

Detail

  • Isolating the import and configuration for each of the Athena cache unit tests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 5925e53
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review December 16, 2022 19:50
@LeonLuttenberger LeonLuttenberger self-assigned this Dec 16, 2022
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 5925e53
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 5925e53
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 5925e53
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This failure was related to a transient error with our data quality tests being throttled, unrelated to the Athena cache error.

malachi-constant
malachi-constant approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@malachi-constant malachi-constant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’re awesome for figuring this one out. Great work!

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 4afa2d1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido self-requested a review December 19, 2022 17:32
@malachi-constant malachi-constant merged commit 55369c3 into main Dec 19, 2022
@malachi-constant malachi-constant deleted the fix/athena-cache-pytest-errors branch December 19, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malachi-constant malachi-constant malachi-constant approved these changes

@jaidisido jaidisido jaidisido approved these changes

@cnfait cnfait Awaiting requested review from cnfait

@kukushking kukushking Awaiting requested review from kukushking

Assignees

@LeonLuttenberger LeonLuttenberger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeonLuttenberger @malachi-constant @jaidisido