Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement: Support optional measure_name in wr.timestream.write() #1925

Merged
merged 6 commits into from
Jan 5, 2023
Merged

enhancement: Support optional measure_name in wr.timestream.write() #1925

merged 6 commits into from
Jan 5, 2023

Conversation

malachi-constant
Copy link
Contributor

Enhancement

  • Adds new optional parameter measure_name to wr.timestream.write().
  • Column measure_name can be named to a string value that does not come from any measure column names.
    • This is intended for use with multi-measure records , but is available as an override for single (scalar) records as well.
  • Unit tests for both multi-measure and single record puts are included.

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant linked an issue Jan 5, 2023 that may be closed by this pull request
Specify measure_name as explicit optiona arg when writing multi-measure values to Timestream #1885
Closed
@malachi-constant
Merge branch 'main' into 1885-specify-measure_name-as-explicit-option…
0083cd2 
…a-arg-when-writing-multi-measure-values-to-timestream
@malachi-constant malachi-constant self-assigned this Jan 5, 2023
@malachi-constant malachi-constant added the enhancement New feature or request label Jan 5, 2023
@malachi-constant malachi-constant added this to the 2.19.0 milestone Jan 5, 2023
@malachi-constant malachi-constant mentioned this pull request Jan 5, 2023
Closed
@malachi-constant
doc formatting
bc8d70f
@malachi-constant
Merge branch '1885-specify-measure_name-as-explicit-optiona-arg-when-…
b30f497 
…writing-multi-measure-values-to-timestream' of github.com:aws/aws-sdk-pandas into 1885-specify-measure_name-as-explicit-optiona-arg-when-writing-multi-measure-values-to-timestream
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 0083cd2
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: b30f497
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

jaidisido
jaidisido reviewed Jan 5, 2023
View reviewed changes
Copy link
Contributor

@jaidisido jaidisido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor refactor in tests

tests/test_timestream.py Outdated Show resolved Hide resolved
kukushking
kukushking approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 0d9632b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido self-requested a review January 5, 2023 19:53
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 0d9632b
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 0d9632b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant merged commit 4df8f26 into main Jan 5, 2023
@malachi-constant malachi-constant deleted the 1885-specify-measure_name-as-explicit-optiona-arg-when-writing-multi-measure-values-to-timestream branch January 5, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@jaidisido jaidisido jaidisido approved these changes

@cnfait cnfait Awaiting requested review from cnfait

@LeonLuttenberger LeonLuttenberger Awaiting requested review from LeonLuttenberger

Assignees

@malachi-constant malachi-constant

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.19.0
Development

Successfully merging this pull request may close these issues.

Specify measure_name as explicit optiona arg when writing multi-measure values to Timestream
3 participants
@malachi-constant @kukushking @jaidisido