Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: quicksight test resources as fixtures #1928

Merged
merged 3 commits into from
Jan 6, 2023
Merged

refactor: quicksight test resources as fixtures #1928

merged 3 commits into from
Jan 6, 2023

Conversation

malachi-constant
Copy link
Contributor

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant marked this pull request as draft January 5, 2023 19:57
@malachi-constant malachi-constant self-assigned this Jan 5, 2023
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 126c56d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant marked this pull request as ready for review January 5, 2023 20:41
@malachi-constant malachi-constant added bug Something isn't working enhancement New feature or request labels Jan 5, 2023
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: b2bafd8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

kukushking
kukushking approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@malachi-constant malachi-constant merged commit 3a45833 into main Jan 6, 2023
@malachi-constant malachi-constant deleted the refactor/quicksight-test-resources branch January 6, 2023 17:18
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 0a5ddb7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kukushking kukushking kukushking approved these changes

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@jaidisido jaidisido jaidisido approved these changes

@cnfait cnfait Awaiting requested review from cnfait

Assignees

@malachi-constant malachi-constant

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@malachi-constant @kukushking @LeonLuttenberger @jaidisido