Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: indent categories in pyarrow_additional_kwargs correctly #2701

Merged
merged 3 commits into from Mar 5, 2024
Merged

fix: indent categories in pyarrow_additional_kwargs correctly #2701

merged 3 commits into from Mar 5, 2024

Conversation

jaidisido
Copy link
Contributor

@jaidisido jaidisido commented Mar 4, 2024 •
edited

Feature or Bugfix

  • Bugfix

Detail

  • Fix indentation for categories in _fetch_parquet_result. As it's currently setup, categories is never passed if pyarrow_additional_kwargs is passed by the user

Relates

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jaidisido jaidisido self-assigned this Mar 4, 2024
@jaidisido jaidisido linked an issue Mar 4, 2024 that may be closed by this pull request
dtype_backend overrides categories #2700
Closed
@jaidisido jaidisido mentioned this pull request Mar 4, 2024
Closed
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 89ba63d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: 89ba63d
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: 8dbd2d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubCodeBuild8756EF16-4rfo0GHQ0u9a
  • Commit ID: fc0c8bd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: GitHubDistributedCodeBuild6-jWcl5DLmvupS
  • Commit ID: fc0c8bd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@jaidisido jaidisido merged commit 77f2dc2 into main Mar 5, 2024
19 checks passed
@jaidisido jaidisido deleted the fix/missindented-categories branch March 5, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonLuttenberger LeonLuttenberger LeonLuttenberger approved these changes

@kukushking kukushking Awaiting requested review from kukushking

@malachi-constant malachi-constant Awaiting requested review from malachi-constant

Assignees

@jaidisido jaidisido

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dtype_backend overrides categories
3 participants
@jaidisido @malachi-constant @LeonLuttenberger