Feature/copy creds #485
Merged
Feature/copy creds #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntials from boto3 session.
…nload function. Also updated doc for db_users.
|
Probably need to add tests for using boto3 session. |
igorborgest
added
feature
minor release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to Issue #484
Description of changes:
Allow users to use the credentials in a passed boto3 session (or default boto3 session) to authenticate unloading redshift data to s3. Users should have s3 permissions already to do many s3 operations. Can easily add allowing passing raw credentials if desired.
There was also a bug fix in copy where a boto3 session was not passed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.