Adds compatability for Laravel 6 #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@djfrailey Test cases are failing for lumen. You need to change makefile |
|
Any updates here? Currently blocking us on a few projects from upgrading. I'd be happy to help, but not sure what needs to change in the Makefile |
|
@munir131 Sorry for the late reply everyone. I'll need a little more direction than that, I'm not too sure what needs to happen to the Makefile in order to make Lumen play nice with Laravel's 6.0 components. |
added 3 commits
September 9, 2019 10:37
Prior to this commit Travis was installing either 5.x or 6.x components for Lumen tests. Lumen does not yet have support for 6.x components.
Prior to this commit composer lock file was still present when the Lumen tests ran. This commit removes the lock file inbetween tests so the appropriate version of composer packages may be installed.
|
@djfrailey Thanks for the PR! I played around with this a bit and was able to get the Travis tests passing in #170. Looks like the distribution had to be changed for PHP 5.5 as well. Will also update here when it's merged. |
|
#170 has been merged, so I'll go ahead and close this one out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #168
Description of changes:
Added ~6.0 to the list of allowed versions for the illuminate\support package.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.