Process Provider does not honor 'use_aws_shared_config_files' boolean similar to ini provider

[cuppett]

It appears there is a conditional against the iniProvider here:

aws-sdk-php/src/Credentials/CredentialProvider.php

Lines 89 to 103 in 5b59db8

	if (
	!isset($config['use_aws_shared_config_files'])
	|| $config['use_aws_shared_config_files'] !== false
	) {
	$defaultChain['sso'] = self::sso(
	'profile default',
	self::getHomeDir() . '/.aws/config',
	$config
	);
	$defaultChain['ini'] = self::ini();
	$defaultChain['ini_config'] = self::ini(
	'profile default',
	self::getHomeDir() . '/.aws/config'
	);
	}

And it is not honored in the same way when evaluating for processes:

aws-sdk-php/src/Credentials/CredentialProvider.php

Lines 108 to 112 in 5b59db8

	$defaultChain['process_credentials'] = self::process();
	$defaultChain['process_config'] = self::process(
	'profile default',
	self::getHomeDir() . '/.aws/config'
	);

It is not clear why the ecsProvider is nestled between the two.

I'll file a PR to add the conditional to both stanzas. I can amend it if somebody feels the process method should be adjacent to the iniProvider method.

[SamRemis]

Hi @cuppett,
The PR looks good to me and I can merge soon- I just want to make sure your original issue with the Process Provider has been resolved, since merging it will close this issue

[cuppett]

Yes. That will resolve it. It puts all the logic which considers ~/.aws/credentials and ~/.aws/config underneath the 'use_aws_shared_config_files' boolean check.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.