Make DynamoDB session handler implement native SessionHandlerInterface where possible #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| namespace Aws\DynamoDb\Session; | ||
|
|
||
| if (version_compare(phpversion(), '5.4', '>=')) { |
There was a problem hiding this comment.
Might if (PHP_VERSION_ID >= 50400) work better here? It's designed for comparisons, and version strings can have interesting vendor-specific attributes in them.
There was a problem hiding this comment.
Seems like a good idea :)
|
👍 |
|
👍 Seems like this should help with interoperability with frameworks. I'll submit it for our internal review. I also need you to confirm that you are willing to submit this code under the Apache 2.0 License. Thanks. |
|
I hereby agree to submit this under Apache 2 license :) |
|
Thanks for being a good sport. :-) |
jeremeamia
added a commit
that referenced
this pull request
Sep 10, 2013
Make DynamoDB session handler implement native SessionHandlerInterface where possible
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Projects like Silex accept session handlers that implement \SessionHandlerInterface, which was added to PHP in 5.4.
I've added a version check to make sure this still runs under 5.3 by defining an empty interface.