Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grab credentials from config files #230

Closed
wants to merge 3 commits into from
Closed

Grab credentials from config files #230

wants to merge 3 commits into from

Conversation

clifflu
Copy link

@clifflu clifflu commented Feb 13, 2014

Try to grab credentials from config files if not supplied from Credentials::factory() or Options. Supported formats include aws-cli, aws-credential (old awscli), and boto, detected in alphabetical order.

Test cases included, also fixed the issue to fail some tests if env AWS_ACCESS_KEY_ID and AWS_SECRET_KEY were set.

Fixes failed test cases if AWS_ACCESS_KEY_ID and AWS_SECRET_ACCESS_KEY is set.
@mtdowling
Copy link
Member

Thanks for the PR. We're interested in being able to use the AWS CLI configuration format, but we're still trying to determine to what extent we will support the format.

We're less interested in being able to use the old config format or the Boto config files due to the additional service area, complexity, and implied commitment to supporting these formats now and in the future (i.e., if they change the format). Would you mind removing everything except for the AWS CLI configuration parsing? After that's done, we can more thoroughly review your code.

@clifflu
Copy link
Author

clifflu commented Feb 19, 2014

No problem. Should be done this weekend :)

@skyzyx
Copy link
Contributor

skyzyx commented Feb 28, 2014

👍 for supporting AWS CLI config syntax.

@mtdowling
Copy link
Member

Just want to give you a heads up that we'll likely support the same credentials file as the CLI, but the credentials file that is shared by the CLI and the SDK may change. When integrating this, we'd likely need to make other significant changes (like possibly supporting something equivalent to the CLI's "profiles"). Because this is a larger scoped issued that needs to be resolved first internally, I'm going to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants