Enhancement: S3 StreamWrapper error handling #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 28, 2022 12:58
SamRemis
approved these changes
Jan 28, 2022
added 3 commits
January 28, 2022 13:37
…to streamwrapper-noclose-patch
SamRemis
added a commit
to SamRemis/aws-sdk-php
that referenced
this pull request
Feb 4, 2022
This reverts commit fbb71b7.
SamRemis
added a commit
to SamRemis/aws-sdk-php
that referenced
this pull request
Feb 24, 2022
…"" This reverts commit 08dfebf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1967
Attempting to write to a stream that is not explicitly flushed or closed in a script currently results in confusing errors:
wmode:Fatal error: Uncaught Error: Class 'Aws\Command' not found in /tmp/aws/Aws/AwsClient.php:258xmode:Fatal error: Uncaught Error: Class 'Aws\Api\MapShape' not found in /tmp/aws/Aws/Api/Shape.php:47A similar error is seen in
amode. This happens when the stream's body size has not been determined. Added logic to check for a stream body size ofnull.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.