Query string value lists are serialized as duplicates #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems straight forward enough. Thanks Guzzle. 😄 |
mtdowling
added a commit
that referenced
this pull request
Dec 11, 2014
Query string value lists are serialized as duplicates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to use a duplicate aggregator for all services, I've overridden
createRequestin AbstractClient (used by all clients). This really only affects restful services that binds lists to query strings. This change does not affect query services as those use the customizedaws.querylocation. Signers also do not duplicate header values so they are unaffected. We also already sort multiple query string list values so there was no need to change the signer.Integration tests and unit tests pass.