Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using older composer version syntax to support older builds of composer #595

Merged
merged 2 commits into from
May 28, 2015
Merged

Using older composer version syntax to support older builds of composer #595

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d01c3c0
Using older composer version syntax to support older builds of composer
mtdowling May 28, 2015
c65f79e
Using a less wonky version specifier
mtdowling May 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@
},
"require": {
"php": ">=5.5",
"guzzlehttp/guzzle": "^5.3||^6.0.1",
"guzzlehttp/psr7": "^1.0",
"guzzlehttp/promises": "^1.0",
"mtdowling/jmespath.php": "^2.2"
"guzzlehttp/guzzle": ">=5.3|>=6.0.1,<7",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would do ~5.3||^6.0.1 or ~5.3||~6.0.1||~6.1 if you want to avoid the caret sign.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~5.3||^6.0.1 wouldn't avoid it, and would result in a parse error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~5.3||~6.0.1||~6.1 would work fine.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what parse error?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one you get if you use a really old verion of composer...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what you said is what I said then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, i can't remember the exact error off the top of my head. If you're interested try it out I guess.

"guzzlehttp/psr7": "~1.0",
"guzzlehttp/promises": "~1.0",
"mtdowling/jmespath.php": "~2.2"
},
"require-dev": {
"ext-openssl": "*",
Expand Down