Skip to content
Permalink
Browse files

Minor fix for retries of idempotent http requests.

Fixes #799
  • Loading branch information...
trevorrowe committed May 4, 2015
1 parent c51c3b1 commit 5a005974afcda0ec0c8e9332bed4c70a78443500
Showing with 12 additions and 0 deletions.
  1. +11 −0 CHANGELOG.md
  2. +1 −0 aws-sdk-core/lib/seahorse/client/net_http/patches.rb
@@ -1,6 +1,17 @@
Unreleased Changes
------------------

* Issue - HTTP Handler - Applied a local fix for a Net::HTTP bug. Net::HTTP
will retry failed requests when the request method is idempotent, such as
HTTP GET, PUT, etc. Unfortunately, Net::HTTP will create a new request, but
yield bytes to the same callback after bytes have already been yielded. This
causes the response data sink to contain a truncated response, followed
by a full response. This results in correct data.

The fix current is to disable idempotent retries until this is fixed upstream.

See [related GitHub issue #799](https://github.com/aws/aws-sdk-ruby/pull/799)

* Feature - Aws::S3::Encryption::Client - You can now pass vanilla
client constructor options to the encryption client constructor and these
will pass through when generating the underlying client. This increases
@@ -10,6 +10,7 @@ module Patches
def self.apply!
if RUBY_VERSION >= '2.0'
Net::HTTP.send(:include, Ruby_2)
Net::HTTP::IDEMPOTENT_METHODS_.clear
elsif RUBY_VERSION >= '1.9.3'
Net::HTTP.send(:include, Ruby_1_9_3)
end

0 comments on commit 5a00597

Please sign in to comment.
You can’t perform that action at this time.