Skip to content

Commit

Permalink
Minor fix for retries of idempotent http requests.
Browse files Browse the repository at this point in the history
Fixes #799
  • Loading branch information
trevorrowe committed May 5, 2015
1 parent c51c3b1 commit 5a00597
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
11 changes: 11 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,17 @@
Unreleased Changes
------------------

* Issue - HTTP Handler - Applied a local fix for a Net::HTTP bug. Net::HTTP
will retry failed requests when the request method is idempotent, such as
HTTP GET, PUT, etc. Unfortunately, Net::HTTP will create a new request, but
yield bytes to the same callback after bytes have already been yielded. This
causes the response data sink to contain a truncated response, followed
by a full response. This results in correct data.

The fix current is to disable idempotent retries until this is fixed upstream.

See [related GitHub issue #799](https://github.com/aws/aws-sdk-ruby/pull/799)

* Feature - Aws::S3::Encryption::Client - You can now pass vanilla
client constructor options to the encryption client constructor and these
will pass through when generating the underlying client. This increases
Expand Down
1 change: 1 addition & 0 deletions aws-sdk-core/lib/seahorse/client/net_http/patches.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module Patches
def self.apply!
if RUBY_VERSION >= '2.0'
Net::HTTP.send(:include, Ruby_2)
Net::HTTP::IDEMPOTENT_METHODS_.clear
elsif RUBY_VERSION >= '1.9.3'
Net::HTTP.send(:include, Ruby_1_9_3)
end
Expand Down

0 comments on commit 5a00597

Please sign in to comment.