Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http_proxy is ignored #956

Closed
lox opened this issue Oct 13, 2015 · 3 comments
Closed

http_proxy is ignored #956

lox opened this issue Oct 13, 2015 · 3 comments
Labels
guidance Question that needs advice or information.

Comments

@lox
Copy link

lox commented Oct 13, 2015

Whilst trying to solve 99designs/aws-vault#40 I noticed that aws-sdk-ruby intentionally ignores system proxies.

5af5b8d

What's the rationale? It's different behaviour from the other SDK's that I have looked at.

@trevorrowe
Copy link
Member

To be honest, I don't recall the motivation for ignoring system proxies. Changing this at this point would possibly cause other problems, as some issue likely prompted the change.

I suspect there are valid cases for using the system proxy to contact the instance metadata service and other times where using the system proxy is undesirable or problematic. The problem here is the SDK does not give the user any control over when to use or when to ignore the system proxy.

Would it be sufficient if AWS::Core::CredentialProviders::EC2Provider#initialize accepted a :http_proxy option?

@trevorrowe
Copy link
Member

I also did some additional digging. The Ruby SDK is not the only SDK that disables environment proxies when connecting to the instance metadata service. I spoke with one of the CLI engineers and they do the same thing.

@trevorrowe
Copy link
Member

I'm going to move this to our feature requests. Please feel free to continue commenting on this issue.

awood45 added a commit that referenced this issue Oct 22, 2015
@diehlaws diehlaws added guidance Question that needs advice or information. and removed question labels Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
guidance Question that needs advice or information.
Projects
None yet
Development

No branches or pull requests

3 participants