Verify MD5 checksums returned by SQS #1093
Conversation
tawan
force-pushed
the
issue-1085-sqs-md5
branch
2 times, most recently
from
7ac8542
to
958856e
Compare
|
I took a moment to review this. The code looks good. I had one piece of feedback above we need to address and then I'm happy to merge this in. Good work! |
Verify MD5 checksums returned by SQS for received messages. * Verify checksum of message body. * Verify checksum of message attributes if present. Refer to aws#1085
tawan
force-pushed
the
issue-1085-sqs-md5
branch
from
958856e
to
7d68859
Compare
| attributes = entry[:message_attributes] | ||
| message_response = response.successful.select { |r| r.id == id }[0] | ||
| unless message_response.nil? | ||
| validate_single_message(body, attributes, message_response) |
There was a problem hiding this comment.
@trevorrowe This is the line you mentioned in the previous commit: I simple added a nil check. Only messages which are which are placed in the successful array are verified.
|
@trevorrowe Thanks for your feedback. I incorporated your suggestion. I amended my changes and rebased, therefore your inline comment seems to be gone. I commented the line in question again for some context. |
Verify MD5 checksums returned by SQS
|
Thanks for the contribution! This should go out with our next release. I'm going to do a small amount of refactoring on the tests. We've been moving away from unit testing the handlers in isolation and instead functionally test the client class they are applied to. This has the benefit of ensuring the plugin is applied correctly. Your tests are organized well enough that moving this should be pretty straightforward. |
Verify MD5 checksums returned by SQS for received messages.
Verify checksum of message body.
Verify checksum of message attributes if present.
Refer to MD5 digest verification for SQS message attributes #1085