Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix AWS::S3::Client specs for non-PDT timezones. #2

Merged
merged 1 commit into from Jul 21, 2011
Merged

fix AWS::S3::Client specs for non-PDT timezones. #2

merged 1 commit into from Jul 21, 2011

Conversation

juno
Copy link

@juno juno commented Jul 15, 2011

Spec for AWS::S3::Client is failed when local timezone is not PDT.
I modified expectation strings but its bit more unclear than before.
Have any ideas?

$ bundle exec rspec -cfs ./spec/aws/s3/client_spec.rb

Failures:

  1) AWS::S3::Client#get_object it should behave like formats date header formats Time values
     Failure/Error: client.send(method, my_opts)
       Double "a handler" received :handle but passed block failed with: expected: "Mon, 13 Jun 2011 15:42:31 -0700"
            got: "Tue, 14 Jun 2011 07:42:31 +0900" (using ==)
     Shared Example Group: "formats date header" called from ./spec/aws/s3/client_spec.rb:1110
     # ./lib/aws/base_client.rb:269:in `block in make_sync_request'
     # ./lib/aws/base_client.rb:281:in `retry_server_errors'
     # ./lib/aws/base_client.rb:264:in `make_sync_request'
     # ./lib/aws/base_client.rb:412:in `block (2 levels) in client_request'
     # ./lib/aws/base_client.rb:179:in `block in log_client_request'
     # ./lib/aws/base_client.rb:178:in `log_client_request'
     # ./lib/aws/base_client.rb:375:in `block in client_request'
     # ./lib/aws/base_client.rb:314:in `return_or_raise'
     # ./lib/aws/base_client.rb:374:in `client_request'
     # (eval):3:in `get_object'
     # ./spec/aws/s3/client_spec.rb:679:in `block (3 levels) in <class:S3>'

  2) AWS::S3::Client#get_object it should behave like formats date header formats DateTime values
     Failure/Error: client.send(method, my_opts)
       Double "a handler" received :handle but passed block failed with: expected: "Mon, 13 Jun 2011 15:42:31 -0700"
            got: "Tue, 14 Jun 2011 07:42:31 +0900" (using ==)
     Shared Example Group: "formats date header" called from ./spec/aws/s3/client_spec.rb:1110
     # ./lib/aws/base_client.rb:269:in `block in make_sync_request'
     # ./lib/aws/base_client.rb:281:in `retry_server_errors'
     # ./lib/aws/base_client.rb:264:in `make_sync_request'
     # ./lib/aws/base_client.rb:412:in `block (2 levels) in client_request'
     # ./lib/aws/base_client.rb:179:in `block in log_client_request'
     # ./lib/aws/base_client.rb:178:in `log_client_request'
     # ./lib/aws/base_client.rb:375:in `block in client_request'
     # ./lib/aws/base_client.rb:314:in `return_or_raise'
     # ./lib/aws/base_client.rb:374:in `client_request'
     # (eval):3:in `get_object'
     # ./spec/aws/s3/client_spec.rb:689:in `block (3 levels) in <class:S3>'

  3) AWS::S3::Client#get_object it should behave like formats date header formats Time values
     Failure/Error: client.send(method, my_opts)
       Double "a handler" received :handle but passed block failed with: expected: "Mon, 13 Jun 2011 15:42:31 -0700"
            got: "Tue, 14 Jun 2011 07:42:31 +0900" (using ==)
     Shared Example Group: "formats date header" called from ./spec/aws/s3/client_spec.rb:1111
     # ./lib/aws/base_client.rb:269:in `block in make_sync_request'
     # ./lib/aws/base_client.rb:281:in `retry_server_errors'
     # ./lib/aws/base_client.rb:264:in `make_sync_request'
     # ./lib/aws/base_client.rb:412:in `block (2 levels) in client_request'
     # ./lib/aws/base_client.rb:179:in `block in log_client_request'
     # ./lib/aws/base_client.rb:178:in `log_client_request'
     # ./lib/aws/base_client.rb:375:in `block in client_request'
     # ./lib/aws/base_client.rb:314:in `return_or_raise'
     # ./lib/aws/base_client.rb:374:in `client_request'
     # (eval):3:in `get_object'
     # ./spec/aws/s3/client_spec.rb:679:in `block (3 levels) in <class:S3>'

  4) AWS::S3::Client#get_object it should behave like formats date header formats DateTime values
     Failure/Error: client.send(method, my_opts)
       Double "a handler" received :handle but passed block failed with: expected: "Mon, 13 Jun 2011 15:42:31 -0700"
            got: "Tue, 14 Jun 2011 07:42:31 +0900" (using ==)
     Shared Example Group: "formats date header" called from ./spec/aws/s3/client_spec.rb:1111
     # ./lib/aws/base_client.rb:269:in `block in make_sync_request'
     # ./lib/aws/base_client.rb:281:in `retry_server_errors'
     # ./lib/aws/base_client.rb:264:in `make_sync_request'
     # ./lib/aws/base_client.rb:412:in `block (2 levels) in client_request'
     # ./lib/aws/base_client.rb:179:in `block in log_client_request'
     # ./lib/aws/base_client.rb:178:in `log_client_request'
     # ./lib/aws/base_client.rb:375:in `block in client_request'
     # ./lib/aws/base_client.rb:314:in `return_or_raise'
     # ./lib/aws/base_client.rb:374:in `client_request'
     # (eval):3:in `get_object'
     # ./spec/aws/s3/client_spec.rb:689:in `block (3 levels) in <class:S3>'

Finished in 8.63 seconds
1485 examples, 4 failures

@mattyn
Copy link

mattyn commented Jul 15, 2011

Thanks for the patch, we'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants