Handle EncodingError coming from oj gem #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! Changes looks good to me, could you also update test to cover the "EncodingError" case if possible? |
The |
|
I've added another test case so there is one for each exception type that Oj raises. |
|
@cjyclaire Any other changes I should make on this one? |
cjyclaire
approved these changes
Jul 23, 2019
|
Merged! Thanks for the contribution, will be included in the next release : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds some test coverage for the
Aws::Jsonmodule.Fixes: #1831
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For context, I'm using the
aws-sdk-kinesislibrary which sometimes receives<ServiceUnavailableException/>when writing records. The SDK seems to translate these into failure responses when I don't have theojgem installed, but with it present theEncodingErrorbubbles all the way out of the SDK.