RPCv2 and cbor support #3006
Open
RPCv2 and cbor support #3006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextwoods
reviewed
Apr 16, 2024
build_tools/aws-sdk-code-generator/spec/protocol_tests_spec_helper.rb
Outdated
Show resolved
Hide resolved
alextwoods
reviewed
Apr 16, 2024
gems/aws-sdk-core/lib/aws-sdk-core/cbor/engines/default_cbor_engine.rb
Outdated
Show resolved
Hide resolved
|
|
||
| module Aws | ||
| module Cbor | ||
| Tagged = Struct.new(:tag, :value) do |
There was a problem hiding this comment.
the cbor gem also defines its own Tagged class: https://github.com/cabo/cbor-ruby/blob/master/doclib/cbor/tagged.rb#L6
Which it will return when decoding items.
I think we have two options on how to handle this:
- In our cbor gem engine adaptor, we replace any Cbor Tagged objects with Aws::Taged objects.
- We ensure the intrefaces are the same (ie, remove the use of Struct and just define a class with attr accessors) for our Tagged object. Then just rely no ruby's duck typing.
alextwoods
reviewed
Apr 16, 2024
alextwoods
reviewed
Apr 16, 2024
This reverts commit cec94b1.
alextwoods
reviewed
Apr 30, 2024
| 'union' => false, # should remain false | ||
| 'streaming' => true, | ||
| 'requiresLength' => true, | ||
| 'union' => false, # not ignored - should remain false |
There was a problem hiding this comment.
"not ignored" is slightly confusing. Maybe "handled separately"
jterapin
reviewed
May 1, 2024
| Object.send(:remove_const, :ProtocolsJsonQuery) | ||
| end | ||
|
|
||
| it 'selects query if is the only choice' do |
There was a problem hiding this comment.
I think you meant to say, selects query if it is the only choice here like line 20
| end | ||
|
|
||
| def end_indefinite_collection | ||
| # write the stop sequenece |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP for implementing cbor and smithy rpcv2
Encoder and decoder created by @alextwoods