SigV4 as Default for All Amazon S3 Calls #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove hacks that supported 'S3 Signer' default for many common code paths. Now, SigV4 is always the default and special fallback logic is removed. You can still use the legacy signer, without special fallbacks, by specifying the signature version in your client: `client = Aws::S3::Client.new(signature_version: 's3')`
awood45
force-pushed
the
version-2.2-refactor
branch
from
df4f8ad
to
3e00562
Compare
|
Some notes:
Look for more code comments. |
| @@ -14,7 +14,9 @@ | |||
| break if objects.empty? | |||
| @client.delete_objects(bucket: bucket, delete: { objects: objects }) | |||
| end | |||
| puts "MADE IT TO DELETING BUCKET" | |||
There was a problem hiding this comment.
Be sure to remove the pair of debug statements here.
No longer relevant, simply forgot to delete earlier.
Changes some comments and stylistic points, as well as expanding the "incorrect signer" exception to list the two accepted signer types.
Uses s3.amazonaws.com over s3-external-1.amazonaws.com for the us-east-1 region.
trevorrowe
added a commit
that referenced
this pull request
Nov 12, 2015
SigV4 as Default for All Amazon S3 Calls
awood45
added a commit
that referenced
this pull request
Nov 12, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove hacks that supported 'S3 Signer' default for many common code
paths. Now, SigV4 is always the default and special fallback logic is
removed.
You can still use the legacy signer, without special fallbacks, by
specifying the signature version in your client:
client = Aws::S3::Client.new(signature_version: 's3')Resolves issue #949 and may be related to issue #965