Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudwatchlogs.QueryStatusTimeout and cloudwatchlogs.QueryStatusUnknown missing #49

Closed
3 tasks done
jszwedko opened this issue Mar 25, 2020 · 4 comments
Closed
3 tasks done
Labels
feature-request New feature or request logs

Comments

@jszwedko
Copy link

Confirm by changing [ ] to [x] below to ensure that it's a bug:

Describe the bug

There appear to be two missing CloudWatch Insights query statuses.

cloudwatchlogs.QueryStatusUnknown which is documented in the QueryInfo page referred to by DescribeQueries.

cloudwatchlogs.QueryStatusTimeout which is noticeably missing from QueryInfo but is mentioned by GetQueryResults. That page also has a discrepancy between the two lists for the status key documentation.

We have personally observed a status of Timeout being returned by the SDK. We haven't seen Unknown.

Version of AWS SDK for Go?

v1.29.32

Version of Go (go version)?

go version go1.14 linux/amd64

To Reproduce (observed behavior)

Run an Insights query via StartQuery that times out. I'm not sure exactly how to induce that, but we have observed it in production a number of times.

Expected behavior

That cloudwatchlogs.QueryStatusUnknown and cloudwatchlogs.QueryStatusTimeout are defined.

@diehlaws diehlaws self-assigned this Mar 27, 2020
@diehlaws
Copy link

Hi @jszwedko, thanks for reaching out to us about this. This looks to be caused by a mismatch between the statuses the service actually returns and the statuses defined in the API model for the service. We use the API models provided to us by service teams to generate the code for the various service clients, since these statuses are not defined in the model they are not present in the generated client for cloudwatchlogs.

I've reached out to the CloudWatch Logs team about having these statuses added to the API model, once I hear back from them I will update the issue accordingly.

@diehlaws diehlaws removed their assignment Aug 26, 2020
@skmcgrail skmcgrail transferred this issue from aws/aws-sdk-go Mar 26, 2021
@ajredniwja ajredniwja added feature-request New feature or request service-api This issue pertains to the AWS API labels May 3, 2021
@RCHowell
Copy link

RCHowell commented May 25, 2021

@stobrien89 stobrien89 added logs and removed service-api This issue pertains to the AWS API labels Jul 26, 2021
@debora-ito
Copy link
Member

Thank you for pointing it out @RCHowell. QueryStatus now include Timeout and Unknown values.

I'll go ahead and close this, feel free to reach out if you have any other request.

@github-actions
Copy link

This issue is now closed.

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request logs
Projects
None yet
Development

No branches or pull requests

6 participants