Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial Source Commit #1

Merged
merged 4 commits into from
Mar 8, 2019
Merged

Initial Source Commit #1

merged 4 commits into from
Mar 8, 2019

Conversation

rstevens011
Copy link
Contributor

Issue #, if available:

Description of changes:
Adding sanitized source code to github

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rstevens011 rstevens011 self-assigned this Mar 6, 2019
@rstevens011 rstevens011 requested a review from a team March 6, 2019 00:19
@parimaldeshmukh
Copy link
Contributor

We should append a UserAgent similar to -

https://github.com/aws/aws-secretsmanager-caching-java/blob/master/src/main/java/com/amazonaws/secretsmanager/caching/cache/internal/VersionInfo.java

https://github.com/aws/aws-secretsmanager-caching-java/blob/master/src/main/java/com/amazonaws/secretsmanager/caching/cache/SecretCacheObject.java#L128-L131

@rstevens011 rstevens011 requested a review from gbailey March 6, 2019 22:57
@rstevens011 rstevens011 merged commit a84fc92 into aws:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbailey gbailey gbailey approved these changes

Assignees

@rstevens011 rstevens011

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rstevens011 @parimaldeshmukh @gbailey