Revert azure-pipelines-task-lib to 2.12.2 to mitigate shelljs bundling issue #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background
This is a follow-up pr to fix the issue in #522.
Mark shelljs as external for esbuild bundling attempted to address this issue, but was not a successful solution for all of our tasks, as some of our tasks need the commands present in ShellJS.
Problem
This issue emerged with the bump of
azure-pipelines-task-lib
dependency in: #473.Problem detailed in the open issue on
azure-pipelines-task-lib
repo: Cannot use JS bundler because of shelljs dependency.Essentially, the toolkit takes a dependency on
azure-pipelines-task-lib
which takes an additional dependency on ShellJS. Our toolkit uses the esbuild JS Bundler to build the extension. This fails to bundle ShellJS because it uses dynamic require statements (problematic ShellJS code) instead of explicit require statements, which prevents bundlers from correctly analyzing the dependencies.ShellJS has no plans to accommodate these explicit requires statements
Solution
Before making any larger scale changes, let's get
azure-pipelines-task-lib
back to its last known healthy state (working version we used for last release). This PR addresses that.Future
azure-pipelines-task-lib
updatesWhenever we next bump the
azure-pipelines-task-lib
major version, we'll need to keep an eye on updates to microsoft/azure-pipelines-task-lib#942 for any new fixes or workarounds. Current known workarounds involve forking the ShellJS repository, making the necessary changes to ShellJS, and overriding the ShellJS dependency inpackage.json
with the forked version.requires
statementsTesting
node <path-to-task>
) to confirm output matches expectationsChecklist
npm run newChange
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.