Move help link to code

aws · Jun 11, 2020 · 02097fa · 02097fa
1 parent 26b9fb1
commit 02097fa
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/jetbrains-core/src/software/aws/toolkits/jetbrains/core/help/HelpIds.kt b/jetbrains-core/src/software/aws/toolkits/jetbrains/core/help/HelpIds.kt
@@ -62,6 +62,10 @@ enum class HelpIds(shortId: String, val url: String) {
         "sam.install",
         "https://docs.aws.amazon.com/serverless-application-model/latest/developerguide/serverless-sam-cli-install.html"
     ),
+    CFN_LINT(
+        "cloudformation.linter",
+        "https://github.com/aws-cloudformation/cfn-python-lint/blob/master/README.md"
+    )
     ;
 
     val id = "aws.toolkit.$shortId"

diff --git a/jetbrains-core/src/software/aws/toolkits/jetbrains/settings/AwsSettingsConfigurable.java b/jetbrains-core/src/software/aws/toolkits/jetbrains/settings/AwsSettingsConfigurable.java
@@ -86,7 +86,7 @@ private void createUIComponents() {
         cloudDebugExecutablePath = createCliConfigurationElement(getCloudDebugExecutableInstance(), CLOUDDEBUG);
         samHelp = createHelpLink(HelpIds.SAM_CLI_INSTALL);
         samExecutablePath = createCliConfigurationElement(getSamExecutableInstance(), SAM);
-        cfnLintHelp = createHelpLink("cloudformation.linter.install_url");
+        cfnLintHelp = createHelpLink(HelpIds.CFN_LINT);
         cfnLintExecutablePath = createCliConfigurationElement(getCfnLintExecutableInstance(), CFNLINT);
     }
 

diff --git a/resources/resources/software/aws/toolkits/resources/localized_messages.properties b/resources/resources/software/aws/toolkits/resources/localized_messages.properties
@@ -173,7 +173,6 @@ cloudformation.execute_change_set.success=Successfully executed change set again
 cloudformation.execute_change_set.success.title=Successfully executed change set
 cloudformation.key_not_found={0} not found on {1}
 cloudformation.linter.general_error=Error running CloudFormation linter: 
-cloudformation.linter.install_url=https://github.com/aws-cloudformation/cfn-python-lint/blob/master/README.md
 cloudformation.missing_property=Property {0} not found in {1}
 cloudformation.stack.delete.action=Delete Stack...
 cloudformation.stack.logical_id=Logical ID