Skip to content

Commit

Permalink
Remove SdkWaiterUtils due to broken by design (#2568)
Browse files Browse the repository at this point in the history
Not all returned exceptions are errors (S3) which makes this unwrapper broken by design
  • Loading branch information
abrooksv committed Apr 20, 2021
1 parent 3477aa9 commit 3eb5ddf
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 42 deletions.
Expand Up @@ -11,7 +11,6 @@ import software.aws.toolkits.jetbrains.services.lambda.upload.FunctionDetails
import software.aws.toolkits.jetbrains.utils.execution.steps.Context
import software.aws.toolkits.jetbrains.utils.execution.steps.MessageEmitter
import software.aws.toolkits.jetbrains.utils.execution.steps.Step
import software.aws.toolkits.jetbrains.utils.response
import software.aws.toolkits.resources.message

class CreateLambda(private val lambdaClient: LambdaClient, private val details: FunctionDetails) : Step() {
Expand Down Expand Up @@ -52,7 +51,7 @@ class CreateLambda(private val lambdaClient: LambdaClient, private val details:
}

messageEmitter.emitMessage(message("lambda.workflow.update_code.wait_for_stable"), isError = false)
val response = lambdaClient.waiter().waitUntilFunctionExists() { it.functionName(details.name) }.response()
val response = lambdaClient.waiter().waitUntilFunctionExists() { it.functionName(details.name) }.matched().response().get()

// Also wait for it to become active
lambdaClient.waiter().waitUntilFunctionActive { it.functionName(details.name) }
Expand Down

This file was deleted.

This file was deleted.

0 comments on commit 3eb5ddf

Please sign in to comment.