Enable execution of SAM from existing template #314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #314 +/- ##
============================================
- Coverage 48.77% 42.62% -6.15%
- Complexity 254 277 +23
============================================
Files 92 94 +2
Lines 2282 2442 +160
Branches 295 332 +37
============================================
- Hits 1113 1041 -72
- Misses 1072 1284 +212
- Partials 97 117 +20
Continue to review full report at Codecov.
|
abrooksv
suggested changes
Oct 19, 2018
| val element = context.psiLocation ?: return false | ||
| val parent = element.parent |
There was a problem hiding this comment.
Why does setup require the parent, yet isConfigfromContext doesnt?
Are the contexts not equal?
There was a problem hiding this comment.
good catch - added a test and fixed the logic.
| val keyValue = element as? YAMLKeyValue ?: return null | ||
| val value = keyValue.value as? YAMLMapping ?: return null | ||
| val type = value.getKeyValueByKey("Type")?.valueText ?: return null | ||
| if (type != FUNCTION_TYPE) { |
There was a problem hiding this comment.
Should we support AWS::Lambda::Function too, since that can also be used inside a SAM template?
| } | ||
|
|
||
| private void updateComponents() { | ||
|
|
There was a problem hiding this comment.
extra line
Suggested change
|
|
||
| private void updateFunctionModel(List<SamFunction> functions) { | ||
| functionModels.removeAllElements(); | ||
| if (functions.size() == 0) { |
There was a problem hiding this comment.
functions.setEnabled(!functions.isEmpty())
| @@ -0,0 +1,15 @@ | |||
| AWSTemplateFormatVersion: '2010-09-09' | |||
There was a problem hiding this comment.
nothing it's just the dummy file that i often use as a manual test project
kiiadi
force-pushed
the
kiiadi/adding-template-support
branch
from
49840b3
to
ce88cdd
Compare
kiiadi
force-pushed
the
kiiadi/adding-template-support
branch
from
ce88cdd
to
fb2c905
Compare
abrooksv
approved these changes
Oct 19, 2018
kiiadi
force-pushed
the
kiiadi/adding-template-support
branch
from
fb2c905
to
bbc1bf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Description
Current SAM workflows generate a dummy template on the fly, this feature enables the use of an existing template from within the project.
One can also create run configurations from the YAML template directly.
Motivation and Context
Best practice is to define functions as part of an infrastructure template - this enables debugging locally from such a template.
Related Issue(s)
#261
Testing
New tests added.
Screenshots (if appropriate)
Checklist
gradlew checksucceedsLicense
I confirm that my contribution is made under the terms of the Apache 2.0 license.