Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(codewhisperer): make CWSPR connection application wide #3658

Closed
wants to merge 9 commits into from
Closed

feat(codewhisperer): make CWSPR connection application wide #3658

wants to merge 9 commits into from

Conversation

zixlin7
Copy link
Contributor

@zixlin7 zixlin7 commented May 9, 2023 •
edited
Loading

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

moved to #3671

Screen.Recording.2023-05-12.at.2.21.42.PM.mov

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zixlin7 zixlin7 requested a review from andrewyuq May 9, 2023 20:33
andrewyuq
andrewyuq reviewed May 9, 2023
View reviewed changes
Copy link
Contributor

@andrewyuq andrewyuq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A E2E flow showing CW connection is stored in the application-scope aws.xml can be attached in the PR.
Also if there are not tests for ToolkitConnectionManager application services, we should also add to this PR.

...tware/aws/toolkits/jetbrains/services/codewhisperer/codescan/CodeWhispererCodeScanManager.kt Outdated Show resolved Hide resolved
...ns-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/util/CodeWhispererUtil.kt Outdated Show resolved Hide resolved
andrewyuq
andrewyuq approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@andrewyuq andrewyuq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good enough.
Just to make sure, could you also verify that the states are persisted in
~/Library/Application Support/JetBrains/<your ide version>/options/aws.xml?

...ns-core/src/software/aws/toolkits/jetbrains/services/codewhisperer/util/CodeWhispererUtil.kt Outdated Show resolved Hide resolved
@zixlin7
Copy link
Contributor Author

zixlin7 commented May 10, 2023

this looks good enough. Just to make sure, could you also verify that the states are persisted in ~/Library/Application Support/JetBrains/<your ide version>/options/aws.xml?

yes updated a video for this in the PR description

@zixlin7 zixlin7 marked this pull request as ready for review May 10, 2023 16:12
@zixlin7 zixlin7 requested review from a team as code owners May 10, 2023 16:12
@zixlin7 zixlin7 requested a review from rli May 10, 2023 16:12
@zixlin7 zixlin7 marked this pull request as draft May 11, 2023 23:23
@zixlin7 zixlin7 marked this pull request as ready for review May 11, 2023 23:58
@zixlin7 zixlin7 requested a review from andrewyuq May 11, 2023 23:58
@sonarcloud
Copy link

sonarcloud bot commented May 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@zixlin7 zixlin7 requested a review from rli May 12, 2023 21:24
@zixlin7 zixlin7 closed this May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewyuq andrewyuq andrewyuq approved these changes

@rli rli Awaiting requested review from rli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zixlin7 @rli @andrewyuq