Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surface error message to users if plugin can't read aws/config file #4513

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

Will-ShaoHua
Copy link
Contributor

@Will-ShaoHua Will-ShaoHua commented May 24, 2024

Problem

When the plugin can't read config file (possible root cause is invalid format like space characters) or file R/W access), the login flow will return and we're not surfacing the error to users so that the login flow seems to be ir-responsive after users clicking login button.

#4509

Solution

surface the error to users

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Description

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • A short description of the change has been added to the CHANGELOG if the change is customer-facing in the IDE.
  • I have added metrics for my changes (if required)

License

I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Will-ShaoHua Will-ShaoHua requested a review from a team as a code owner May 24, 2024 21:38
@Will-ShaoHua Will-ShaoHua marked this pull request as draft May 24, 2024 22:01
@Will-ShaoHua Will-ShaoHua changed the title remove println used for dev and change to log.warn wip: remove println used for dev and change to log.warn May 24, 2024
@Will-ShaoHua Will-ShaoHua marked this pull request as ready for review June 11, 2024 17:37
@Will-ShaoHua Will-ShaoHua changed the title wip: remove println used for dev and change to log.warn remove println used for dev and change to log.warn Jun 11, 2024
Copy link

sonarcloud bot commented Jun 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

@Will-ShaoHua Will-ShaoHua changed the title remove println used for dev and change to log.warn surface error message to users if plugin can't read aws/config file Jun 11, 2024
@Will-ShaoHua
Copy link
Contributor Author

Will-ShaoHua commented Jun 11, 2024

should figure out a better way to do this, maybe a toast notification, but will leave it as a followup

@Will-ShaoHua Will-ShaoHua merged commit 4e5b072 into aws:main Jun 11, 2024
9 of 11 checks passed
@Will-ShaoHua Will-ShaoHua deleted the log branch June 11, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants