Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist SageMakerRuntime InvokeEndpoint operation #154

Merged
merged 4 commits into from
Jan 2, 2020

Conversation

jknollmeyer
Copy link
Contributor

Operation name and request param acquired from this documentation:
https://docs.aws.amazon.com/sdk-for-go/api/service/sagemakerruntime/

Sample subsegment from end-to-end test, works as expected:

{
    "id": "07fe70440891ace9",
    "name": "SageMaker",
    "start_time": 1574375614.193963,
    "end_time": 1574375614.719934,
    "parent_id": "a44a28708794302f",
    "inferred": true,
    "http": {
        "response": {
            "status": 200,
            "content_length": 3
        }
    },
    "aws": {
        "endpoint_name": "test-endpoint-1",
        "operation": "InvokeEndpoint",
        "region": "us-east-1",
        "request_id": "6da963c7-d04e-4ab2-b93e-db012b19fa8e",
        "retries": 0,
        "resource_names": [
            "test-endpoint-1"
        ]
    },
    "trace_id": "1-5dd710be-f3ee90a256c11ab35e722768",
    "origin": "AWS::SageMaker::Endpoint"
}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jknollmeyer
Copy link
Contributor Author

Careful attention to the bindata.go file would be helpful. The file that was generated by make changed a lot more than just the whitelist blob, even though I only changed the whitelisting JSON file.

Is it possible that there were previous changes which affected bindata.go, but the file wasn't regenerated?

@bhautikpip bhautikpip self-requested a review January 2, 2020 23:11
@bhautikpip bhautikpip merged commit a8e4b34 into aws:master Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants