fix datarace for http2 #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luluzhao
suggested changes
Oct 19, 2018
xray/client_test.go
Outdated
| @@ -225,3 +228,42 @@ func TestRoundTrip_reuse_datarace(t *testing.T) { | |||
| } | |||
| wg.Wait() | |||
| } | |||
|
|
|||
| func TestRoundTrip_http2_datarace(t *testing.T) { | |||
There was a problem hiding this comment.
Nitpick.... Could we rename this function to be "TestRoundTripHttp2Datarace"? Since we haven't used underscore in naming our functions, it would be good to keep consistency.
luluzhao
approved these changes
Oct 23, 2018
|
@t-yuki merged. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #71
*Description of changes: Unit test and quick fix of http2 datarace reported in #71
However, it may have other problems by race since this is only a trivial patch.
Also, since httptest.NewRequest is for server side incoming requests, as noted in the document, we should use http.NewRequest.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.