Avoid String.split when parsing header to reduce some garbage generat… #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ion.
Description of changes:
Instead of String.split, can use indexOf to reduce allocations of arrays. About 20% faster / less allocations, not huge but these things add up and as instrumentation we need to keep an eye on minimizing cycles to reduce the cost burden of the customer. I would say the readability is not significantly impaired. @shengxil feel free to copy this away.
After
Before
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.