Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added aggregate javadoc plugin #242

Merged
merged 2 commits into from
Nov 30, 2020
Merged

added aggregate javadoc plugin #242

merged 2 commits into from
Nov 30, 2020

Conversation

willarmiros
Copy link
Contributor

Description of changes:
We need to aggregate all javadocs at the top-level to publish them publicly. This tool generates them with:

./gradlew aggregateJavadoc

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@willarmiros
Copy link
Contributor Author

Switched to plugin for aggregate javadoc jar, which does the same javadoc generation as the previous plugin, but also allows for the ability to create an aggregate jar with ./gradlew aggregateJavadocJar, which is what our system actually needs.

Copy link
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, how do we publish the javadoc? Is it something we can add to the release workflow?

@willarmiros
Copy link
Contributor Author

@anuraaga I don't think so unfortunately, the javadocs are currently deployed to an internally-managed host. We can discuss today about their current architecture.

@willarmiros willarmiros merged commit 1789316 into aws:master Nov 30, 2020
@willarmiros willarmiros deleted the javadoc branch November 30, 2020 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants