fix(core): fixes custom recorder race condition with servlet filter #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not be used if set after the AWSXrayServletFilter was instantiated
haotianw465
approved these changes
Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#51
Description of changes:
Updates
AWSXRayServletFilterandAWSXRayServletAsyncListenerto lazily retrieve the global xray recorder if none was provided at instantiation.This fixes a race condition in the following scenario caused when the global recorder is set to a custom recorder after the
AWSXRayServletFilteris instantiated. In this scenario, the global recorder that existed when the servletFilter was instantiated would be used instead of the custom recorder.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.