feat:IGNORE_ERROR context missing strategy #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willarmiros
approved these changes
Oct 22, 2020
Comment on lines
-149
to
+151
| assert.notEqual(ContextUtils.contextMissingStrategy.contextMissing, RUNTIME_ERROR_FCN_NAME); | ||
| assert.equal(ContextUtils.contextMissingStrategy.contextMissing.name, RUNTIME_ERROR_FCN_NAME); |
There was a problem hiding this comment.
Not sure what was going on in this test before, thanks :)
|
The Travis failure is a problem in the Koa patcher and only occurs in Node 15, and it is unrelated to this PR. We should fix the issue in the Koa ASAP to not have these misleading CI failures. Merging because the changes for this PR are not problematic. |
|
Nice. For anyone who wants this behavior early, here is a workaround:
|
|
Thanks for the pointer! The only thing I'd add is with respect to:
I've verified you can also set the environment variable to no value in the Lambda Console for the same effect, if you're not using any kind of infra-as-code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
IGNORE_ERRORcontext missing strategy, this is especially useful when running Lambda code/libraries locally to not pollute logs with many lines of context missing.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.