Fix rowMode='array' in postgres patcher #363
Conversation
|
I am still not sure this works, I had some weird behavior in xray but may be unrelated. |
|
Hi @isaacl, Thanks for this contribution, do you think you could add a unit test to verify this fixes the problematic behavior? |
|
OK I did a more involved patch where I use the argument logic from the pg module itself. |
| }); | ||
|
|
||
| it('should pass down raw sql query', function() { | ||
| query.call(postgres, 'sql here', ['values']); |
There was a problem hiding this comment.
Can we also assert that addNewSubsegment is calledOnce in both of these tests? I know we're already testing it in other tests, but since this specific use case was broken before I want to ensure it fully works now.
There was a problem hiding this comment.
Thanks again! Verified with previous versions of the pg library that this change will be backwards compatible, since the query() API hasn't really changed apart from adding the query config object as an alternative to a string for the first argument, which this change adds support for.
* Fix rowMode='array' in postgres patcher * Rewrite pg argument handling logic * Add called assertion to postgres tests
|
can haz release? |
The patcher incorrectly strips rowMode from calls of the form:
c.query({ text: , rowMode: 'array' })
Fixes #364.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.